[Android, iOS] Throw exceptions consistently for invalid StaticResource references to prevent relaunch crashes #33859
+50
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es on iOS only when not debugging
dotnet-policy-service
bot
added
the
partner/syncfusion
Vignesh-SF3580
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
When an invalid template name is provided, the app crashes on Android and iOS when relaunching the app.
Root Cause
Inconsistent exception handling in StaticResourceExtension - it returned null when an exception handler was present but threw an exception when debugger is not attached.
Description of Change
Modified StaticResourceExtension.cs and ApplyPropertiesVisitor.cs to always throw exceptions for invalid StaticResource references, regardless of whether an exception handler is present. Previously, the code returned null and allowing the app to continue. The fix ensures consistent behavior by creating the exception once, optionally logging it through the exception handler if available, and then always throwing it.
Tested the behavior in the following platforms
Issues Fixed
Fixes #23903
Screenshots
iOS:
23903BeforeiOS.mov
23903AfteriOS.mov
Android:
23903AndroidBefore.mov
23903AndroidAfter.mov